small update from personal review

elastic · Feb 20, 2020 · f398cfa · f398cfa
1 parent ceaf478
commit f398cfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/combo_box/combo_box.tsx b/src/components/combo_box/combo_box.tsx
@@ -153,7 +153,7 @@ export class EuiComboBox<T> extends Component<
       return;
     }
 
-    if (!listElement || !listElement) {
+    if (!listElement) {
       return;
     }
 
@@ -489,7 +489,7 @@ export class EuiComboBox<T> extends Component<
     const singleSelection = Boolean(singleSelectionProp);
     const changeOptions = singleSelection
       ? [addedOption]
-      : [...selectedOptions, addedOption];
+      : selectedOptions.concat(addedOption);
 
     if (onChange) {
       onChange(changeOptions);

diff --git a/src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx b/src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
@@ -229,7 +229,7 @@ export class EuiComboBoxOptionsList<T> extends Component<
           </p>
         );
       }
-    } else if (!options || options.length === 0) {
+    } else if (!options.length) {
       emptyStateContent = (
         <p>
           <EuiI18n