-
[When] the code example is given in sandbox and the code modified can be locally run and seen on elastic documentation website. So many a times when I fix an issue and the bug is reproduced in codesandbox, Its hard for me to replicate that in locally build doc website. Can you please tell us what to do in these cases? Originally posted by @hetanthakkar1 in #4816 (comment) |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
There are a couple ways to approach this in the pull request and would depend on how complicated the problem is to replicate. 1. If the bug is a simple use-case scenario, replicate it locally and past before/after screenshots in the PR summary.This obviously also only applies to fixes that are visual based, not purely code fixes. A great example is this PR #4738 which fixes a bug and shows the before/after screenshot so we know what to look for/that the fix worked. 2. If the bug is more complicated to replicate, but shouldn't have a specific doc example (use-case dependent), create a commit that is called
|
Beta Was this translation helpful? Give feedback.
-
2023 answer/follow-up: we should prefer to use Storybook for visual bugs in the future if possible, and visual snapshots. |
Beta Was this translation helpful? Give feedback.
There are a couple ways to approach this in the pull request and would depend on how complicated the problem is to replicate.
1. If the bug is a simple use-case scenario, replicate it locally and past before/after screenshots in the PR summary.
This obviously also only applies to fixes that are visual based, not purely code fixes. A great example is this PR #4738 which fixes a bug and shows the before/after screenshot so we know what to look for/that the fix worked.
2. If the bug is more complicated to replicate, but shouldn't have a specific doc example (use-case dependent), create a commit that is called
Revert me
with one of the doc examples updated for reviewers to test. Then revert …