Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiBasicTable header names should be node propType #1002

Closed
sorenlouv opened this issue Jul 11, 2018 · 7 comments
Closed

EuiBasicTable header names should be node propType #1002

sorenlouv opened this issue Jul 11, 2018 · 7 comments
Assignees

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Jul 11, 2018

With KUI Tables it was possible to add tooltips to the header cells. This is useful since some columns need to be explained to the user. In APM we have a column called "Impact" with a tooltip saying: Impact shows the most used and slowest endpoints in your service.
screen shot 2018-06-29 at 17 09 11

Implementation

Edit: Option A was selected as the best solution of the two.

Option A) EuiBasicTable currently only support strings as name. By allowing custom elements, it would be possible to customize the header in a very flexible way:

{
  field: 'impact',
  name: (
    <div>Impact <EuiToolTip content="Help text"/></div>
  ),
  sortable: true,
  dataType: 'number'
}

Option B) Another option is to keep the name field limited to strings, but introduce a tooltip field:

{
  field: 'impact',
  name: 'Impact',
  tooltip: 'Impact shows the most used and slowest endpoints in your service.',
  sortable: true,
  dataType: 'number'
}
@cchaos
Copy link
Contributor

cchaos commented Jul 11, 2018

Allowing nodes is the most flexible, as you mentioned. I would vote for that solution.

@sorenlouv sorenlouv self-assigned this Jul 12, 2018
@sorenlouv
Copy link
Member Author

Cool. I'll look into adding support for this sometime next week.

@cjcenizal
Copy link
Contributor

+1 to supporting nodes in headers. We will need this to support localization of table headers. I'm going to change the title to reflect this.

@cjcenizal cjcenizal changed the title Tooltips in EuiBasicTable headers EuiBasicTable header names should be node propType Sep 12, 2018
@chrisronline
Copy link
Contributor

+1

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 24, 2018

I got busy with APM stuff but this is still on my roadmap. I expect that I or someone from the APM team will look into this before 6.5 is released but can't guarantee it.

@chrisronline
Copy link
Contributor

To be clear, we're all advocating for option A right?

@sorenlouv
Copy link
Member Author

yes. Updated the issue to reflect that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants