-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiBasicTable header names should be node propType #1002
Comments
Allowing nodes is the most flexible, as you mentioned. I would vote for that solution. |
Cool. I'll look into adding support for this sometime next week. |
+1 to supporting nodes in headers. We will need this to support localization of table headers. I'm going to change the title to reflect this. |
+1 |
I got busy with APM stuff but this is still on my roadmap. I expect that I or someone from the APM team will look into this before 6.5 is released but can't guarantee it. |
To be clear, we're all advocating for option A right? |
yes. Updated the issue to reflect that! |
With KUI Tables it was possible to add tooltips to the header cells. This is useful since some columns need to be explained to the user. In APM we have a column called "Impact" with a tooltip saying:
Impact shows the most used and slowest endpoints in your service
.Implementation
Edit: Option A was selected as the best solution of the two.
Option A)
EuiBasicTable
currently only support strings asname
. By allowing custom elements, it would be possible to customize the header in a very flexible way:Option B) Another option is to keep the
name
field limited to strings, but introduce atooltip
field:The text was updated successfully, but these errors were encountered: