Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiSwitch doesn't announce its label #1518

Closed
cjcenizal opened this issue Feb 4, 2019 · 2 comments
Closed

EuiSwitch doesn't announce its label #1518

cjcenizal opened this issue Feb 4, 2019 · 2 comments
Assignees
Labels
accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@cjcenizal
Copy link
Contributor

This might just be a bug with the example page ("Form controls"), but VO just announced "Checked, checkbox" when tabbing to the EuiSwitch example. It should also announce the label associated with the switch.

@cchaos cchaos added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Feb 4, 2019
@cchaos
Copy link
Contributor

cchaos commented Feb 4, 2019

It needs and id prop that we're not automatically adding inside the component if it's not passed down. Otherwise there's nothing to hook up the htmlFor attribute to to link the label and checkbox.

@cjcenizal
Copy link
Contributor Author

@cchaos I just took a look at the implementation... it looks like EuiSwitch automatically generates an id if one isn't provided; the problem is that we're just not supplying that to the label. Should be a simple fix. I'll submit a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

No branches or pull requests

2 participants