Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug which prevented EuiSwitch with generated ID from having its label read by VoiceOver #1519

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Fix bug which prevented EuiSwitch with generated ID from having its label read by VoiceOver #1519

merged 2 commits into from
Feb 4, 2019

Conversation

cjcenizal
Copy link
Contributor

Fixes #1518

@cjcenizal cjcenizal requested a review from cchaos February 4, 2019 20:44
cchaos
cchaos approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, just looking at code. Thanks!

@cjcenizal cjcenizal merged commit a88892f into elastic:master Feb 4, 2019
@cjcenizal cjcenizal deleted the bug/switch-auto-id branch February 4, 2019 22:09
@snide snide mentioned this pull request Feb 5, 2019
Closed
@cchaos cchaos mentioned this pull request Feb 5, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @cchaos