Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EUI should stop using aria-describedby for invalid ids in different components #1533

Closed
bhavyarm opened this issue Feb 6, 2019 · 4 comments · Fixed by #2156
Closed

EUI should stop using aria-describedby for invalid ids in different components #1533

bhavyarm opened this issue Feb 6, 2019 · 4 comments · Fixed by #2156
Assignees
@myasonik
Labels
accessibility bug

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Feb 6, 2019

Often when I am testing for accessibility area-describedby shows up with a random id.

I am adding two examples here. But there are others:

The pencil component here:

invalid_area_id

https://dequeuniversity.com/rules/axe/3.1/aria-valid-attr-value?application=AxeChrome

The EUI badge here:

screen shot 2019-02-06 at 9 43 01 am

I have also seen it on tooltips
@chandlerprall
Copy link
Contributor

Confirmed that table action icons in EUI docs use aria-describedby with a non-existent ID. Same issue exists for at least beta badge on EUI docs page.

@bhavyarm bhavyarm changed the title EUI should stop using area-describedby for invalid ids in different components EUI should stop using aria-describedby for invalid ids in different components Jun 21, 2019
@bhavyarm
Copy link
Contributor Author

Other examples. Running axe on dashboard listing page shows 26 violations. The side bar has invalid ids :
Screen Shot 2019-06-21 at 10 50 36 AM

@bhavyarm
Copy link
Contributor Author

cc @barlowm

@bhavyarm
Copy link
Contributor Author

@myasonik

@myasonik myasonik self-assigned this Jul 22, 2019
myasonik pushed a commit to myasonik/eui that referenced this issue Jul 23, 2019
Fix invalid aria-describedby values set by EuiToolTip (elastic#1533)
8638dd8
myasonik pushed a commit to myasonik/eui that referenced this issue Jul 23, 2019
Fix invalid aria-describedby values set by EuiToolTip (elastic#1533)
6b3b498
@myasonik myasonik mentioned this issue Jul 23, 2019
Merged
3 tasks
myasonik added a commit that referenced this issue Jul 23, 2019
@myasonik
Fix invalid aria-describedby values set by EuiToolTip (#1533) (#2156)
5e1e67f
thompsongl pushed a commit to thompsongl/eui that referenced this issue Sep 10, 2019
@myasonik @thompsongl
Fix invalid aria-describedby values set by EuiToolTip (elastic#1533) (e…
8699af4 
…lastic#2156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myasonik myasonik

Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid aria-describedby values set by EuiToolTip (#1533) myasonik/eui
3 participants
@chandlerprall @myasonik @bhavyarm