Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) euiNavDrawerFlyout uses <h5> and breaks the structure heading hierachy #2039

Closed
PhilippBaranovskiy opened this issue Jun 13, 2019 · 0 comments · Fixed by #2040
Closed

(Accessibility) euiNavDrawerFlyout uses <h5> and breaks the structure heading hierachy #2039

PhilippBaranovskiy opened this issue Jun 13, 2019 · 0 comments · Fixed by #2040
Assignees
@PhilippBaranovskiy
Labels
accessibility

Comments

@PhilippBaranovskiy
Copy link
Contributor

Associated issue: elastic/kibana#34995

Summary

EuiNavDrawerFlyout components uses <h5> to render a title of the draggable point where tabIndex="-1" is set so nobody can focus on it except using a pointer.

It breaks the heading hierarchy as we can't be sure that <h4> or <h3> is present on a particular page.

Capture

Capture_2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippBaranovskiy PhilippBaranovskiy

Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div> PhilippBaranovskiy/eui
1 participant
@PhilippBaranovskiy