(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div>
#2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippBaranovskiy
changed the title
<h5> by replacing with <div>
|
jenkins, test this |
6 tasks
ryankeairns
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Checked this out locally and it looks good.
It does make me wonder if we're offering a subpar experience for screenreader users given our lack of proper headings, generally speaking. Then again, we don't have control of content and each app is quite different, so I don't see how we could keep that organized enough to be accessible and useful.
One other thought, @snide should we be labeling the EuiNavDrawer as a main navigation region in Kibana?
cchaos
suggested changes
Jun 13, 2019
There was a problem hiding this comment.
I agree with @ryankeairns that more thought should be put into the full accessibility (screen-reader) experience of the nav drawer in association with the application it sits within.
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
cchaos
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2039
Associated issue: elastic/kibana#34995
Summary
This PR replaces
<h5>with<div>and that's it.Checklist
This was checked in mobileThis was checked in IE11This was checked in dark modeAny props added have proper autodocsDocumentation examples were addedThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis required updates to Framer X components