-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to 12.1.0 #39601
Upgrade EUI to 12.1.0 #39601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small nits
x-pack/legacy/plugins/beats_management/public/components/tag/tag_badge.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/draggables/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/properties/helpers.tsx
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little ask, but LGTM from operations
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML changes LGTM 🎉
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
* eui@12.1.0 * jest regenerator-runtime babel-polyfill * TS Toast -> EuiGlobalToastListToast * EuiBadge * EuiCopy * snapshot updates * simplify toast interface usage * misc review cleanup * remove eui core-js resolution
* Upgrade EUI to 12.1.0 (#39601) * eui@12.1.0 * jest regenerator-runtime babel-polyfill * TS Toast -> EuiGlobalToastListToast * EuiBadge * EuiCopy * snapshot updates * simplify toast interface usage * misc review cleanup * remove eui core-js resolution * toast interface import
Summary
eui@11.3.2
⏩eui@12.1.0
Breaking change was removal of
core-js
, which largely only impacted Jest12.1.0
EuiNavDrawerFlyout
title fromh5
todiv
(#2040)EuiGlobalToastList
into ARIA live region by addingrole="region"
attribute to add NVDA/JAWS support (#2055)magnifyWithMinus
andmagnifyWithPlus
glyphs toEuiIcon
(2056)$euiColorInk
(2060)autoFocus
prop toEuiTabbedContent
(2062)popout
glyph inEuiIcon
to look more like external link (2064)SuperDatePicker
to make the start/end date selection more obvious (#2049)toSentenceCase
string service (#2049)EuiSuperSelect
'spopoverClassName
to the popover's panel (#2068)editorItemAlignLeft
,editorItemAlignCenter
,editorItemRight
,editorItemAlignTop
,editorItemAlignMiddle
,editorItemAlignBottom
,editorDistributeHorizontal
,editorDistributeVertical
,editorPositionTopLeft
,editorPositionTopRight
,editorPositionBottomRight
, andeditorPositionBottomLeft
glyphs toEuiIcon
(2070)EuiRange
(#2072)Bug fixes
EuiCopy
'schildren
(#2048)EuiInMemoryTable
to allow sorting on computed columns (#2044)Toast
member export (#2052)EuiFormControlLayout
andprepend
/append
(#2057)EuiBadge
andEuiCopy
(#2052)12.0.0
noreferrer
also to links withouttarget="_blank"
(#2008)EuiCopy
to TypeScript (#2016)magnet
glyph toEuiIcon
(2010)logoAWS
SVG inEuiIcon
to work better in dark mode (#2036)Bug fixes
EuiFlyout
scrolling in Safari (#2033)EuiCallOut
header icon alignment (#2006)EuiInMemoryTable
sort value persistence through lifecycle updates (#2035)EuiColorPicker
positioning and keyboard navigation in certain portal contexts (#2038)Breaking changes
core-js
, but a global polyfill likecore-js@3
is still required (#1982)