Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Magnet 🧲 #2010

Merged
merged 9 commits into from
Jun 12, 2019
Merged

[Icons] Magnet 🧲 #2010

merged 9 commits into from
Jun 12, 2019

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Jun 7, 2019 •
edited
Loading

Summary

Added a new magnet icon to be used in the editor controls for Canvas and Viz editor.

Screenshot 2019-06-12 at 19 59 49

Screenshot 2019-06-12 at 20 00 33

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@formgeist
Icon: Magnet
239b51e 
Added a new `magnet` icon.
@formgeist formgeist added the icons label Jun 7, 2019
@formgeist formgeist requested a review from cchaos June 7, 2019 17:53
@formgeist formgeist self-assigned this Jun 7, 2019
snide
snide suggested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run yarn compile-icons (this is new) and add a changelog. Looks like the fill is still there so it's busted in dark mode. Easy fixes.

image

@formgeist
Copy link
Contributor Author

@snide Thanks for the heads up on the new compiler. And I forgot to edit the actual SVG when I added it, so removed those unneeded fills. It should work in dark mode now. And lastly, added a changelog item.

@cchaos
Copy link
Contributor

cchaos commented Jun 7, 2019

@formgeist I'm going to toss you some notes over in Abstract

@formgeist formgeist requested a review from snide June 12, 2019 12:51
cchaos
cchaos approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thanks @formgeist

@formgeist
Copy link
Contributor Author

@snide Are you good with the updates?

@formgeist formgeist merged commit 6a28d3f into elastic:master Jun 12, 2019
@formgeist formgeist deleted the icon-magnet branch June 12, 2019 20:28
@thompsongl thompsongl mentioned this pull request Jun 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide snide approved these changes

Assignees

@formgeist formgeist

Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@formgeist @cchaos @snide