Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change callout docs to using alert icon, aws logo updated for dark mode #2036

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Jun 12, 2019

Summary

Changed the callout docs to use an alert icon for the danger example. Fixes #2024

image

Also changed the AWS logo for dark mode.

image

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Jun 12, 2019
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks!

@snide
Copy link
Contributor Author

snide commented Jun 12, 2019

@cchaos also changed the AWS logo to work in dark mode while we were in there. Blame @hbharding for noticing it!

image

image

@snide snide changed the title Change callout docs to using alert icon Change callout docs to using alert icon, aws logo updated for dark mode Jun 12, 2019
@snide snide merged commit 4c4aa50 into elastic:master Jun 12, 2019
@snide snide deleted the docs/callout branch June 12, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change EuiCallout danger example from using X (cross) as icon
2 participants