(Accessibility) Fixed Kibana home page heading structure #38888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippBaranovskiy
added
Project:Accessibility
Feature:Home
|
Pinging @elastic/kibana-app |
💔 Build Failed |
cchaos
suggested changes
Jun 13, 2019
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
💔 Build Failed |
💚 Build Succeeded |
cchaos
approved these changes
Jun 14, 2019
💚 Build Succeeded |
alexwizp
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Jun 27, 2019
* Fixed <h1> and <h3> => <h2> transition; <h5> issue is fixed in EUI repo;
PhilippBaranovskiy
added a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Jun 28, 2019
* Fixed <h1> and <h3> => <h2> transition; <h5> issue is fixed in EUI repo;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34995
Summary
<h1><h3>with<h2><h5>with<div>in Eui repo<h5>with<div>in Eui repo is merged into Kibana (EUI version 12.0.1)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately