Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some logos are missing a viewBox #2227

Closed
3 tasks
jfsiii opened this issue Aug 14, 2019 · 1 comment · Fixed by #2240
Closed
3 tasks

Some logos are missing a viewBox #2227

jfsiii opened this issue Aug 14, 2019 · 1 comment · Fixed by #2240
Labels
bug

Comments

@jfsiii
Copy link

jfsiii commented Aug 14, 2019

These SVGs are missing a viewBox property
@jfsiii jfsiii added the bug label Aug 14, 2019
@jfsiii
Copy link
Author

jfsiii commented Aug 14, 2019

I see this has been an issue before.

I don't know the process, but perhaps a check like this one could be added as a commit hook or somewhere in the release pipeline?

This was referenced Aug 20, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add viewBox attribute to SVG & JS logo icons where missing jfsiii/eui
1 participant
@jfsiii