Add viewBox attribute to SVG & JS logo icons where missing
#2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
approved these changes
Aug 20, 2019
cchaos
reviewed
Aug 20, 2019
jfsiii
force-pushed
the
2227-add-viewbox
branch
from
f6b7d82 to
d6150c5
Compare
|
ok. just did a rebase & force push |
cchaos
reviewed
Aug 20, 2019
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ No public interface changes since `13.4.0`. | |||
| - Added missing `onChange` TS defs for EuiRange ([#2211](https://github.com/elastic/eui/pull/2211)) | |||
| - Fixed `EuiBadge` text cursor to default pointer ([#2234](https://github.com/elastic/eui/pull/2234)) | |||
| - Fixed `EuiPageContent` className prop to allow the passed-in className to take cascade precedence over classes generated by the component ([#2237](https://github.com/elastic/eui/pull/2237)) | |||
| - Added `viewBox` attribute to Docker, Kubernetes, and Redis logos ([#2240](https://github.com/elastic/eui/pull/2240)) | |||
There was a problem hiding this comment.
Because of the rebase and release, you'll now need to move this line to be under master. And if you don't mind, also copy the **Bug fixes** header up there as well.
There was a problem hiding this comment.
Sorry, this is confusing, there just happened to be a release while your PR is up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2227
Added
viewBoxvalues (copy-pasted fromlogo_rabbitmq.{js,svg}) to Docker, Kubernetes, and Redis logos.Ran
yarn compile-iconsand checked in Storybook with Light & Dark Mode.Pasted React components directly in my plugin
Current
masterThis PR
Checklist
Checked in mobileChecked in IE11 and FirefoxProps have proper autodocsAdded documentation examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes