-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to 13.4.1 #43717
Upgrade EUI to 13.4.1 #43717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; package.json, TypeScript & snapshot changes are as expected from the EUI changelog
@@ -105,6 +105,7 @@ export class FeatureTable extends Component<Props, {}> { | |||
aria-label={ | |||
checked ? `${record.feature.name} visible` : `${record.feature.name} disabled` | |||
} | |||
label="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question It seems like we're using EuiSwitch
incorrectly now. It looks like we'll be creating an empty label tag next to the switch now.
If we're ok using switches without a label (like our use case here), should we instead be creating the markup without the <label>
tag, and making the label
prop optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @legrego , I meant to call this out specifically.
Accessibility is the reason for the change (cc @myasonik), and I was going to run through the app and find the places with empty labels.
@snide, this seems like a design v. a11y situation, because now that I see it in use, the bare switch seems reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legrego We're going to roll back the changes to EuiSwitch
. Not just because of your concerns, but also some more sticky upgrade migration things we've run into too close to FF.
I'll be closing this PR in favor of one with an altered scope and version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads-up, @thompsongl!
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform changes LGTM
💔 Build Failed |
💔 Build Failed |
Closing this in favor of a forthcoming upgrade PR with an altered scope |
eui@13.3.0 ⏩ eui@13.4.1
Conversion of
EuiSwitch
to TypeScript and to use abutton
is the reason for most of the churn13.4.1
EuiSwitch
to TypeScript (#2243)Bug fixes
viewBox
attribute to Docker, Kubernetes, and Redis logos (#2240)13.4.0
EuiFacetButton
to TypeScript (#2226)onClear
prop to the theEuiDatePicker
component (#2235)onClick
andhref
props onEuiListGroupItem
and converted to TypeScript (#1933)Bug fixes
EuiSwitch
semantics to align with aria roles (#2193)onChange
TS defs for EuiRange (#2211)EuiBadge
text cursor to default pointer (#2234)EuiPageContent
className prop to allow the passed-in className to take cascade precedence over classes generated by the component (#2237)