Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cascade issue with adding className to EuiPageContent #2237

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Fix cascade issue with adding className to EuiPageContent #2237

merged 2 commits into from
Aug 19, 2019

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Aug 16, 2019 •
edited
Loading

Summary

Fixes #2232

Reorders the insertion of className into <EuiPageContent> so that you can use class names to override properties otherwise specified by .euiPageContent--verticalCenter or .euiPageContent--horizontalCenter without using !important. The passed in className will now take precedence.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

snide
snide reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a changelog entry. https://github.com/elastic/eui/blob/master/CHANGELOG.md

You can drop it under bugfix. Please used past tense.

@Zacqary Zacqary merged commit 2c01b2c into elastic:master Aug 19, 2019
@Zacqary Zacqary deleted the 2232-pagecontent-classname-reorder branch August 19, 2019 20:22
This was referenced Aug 21, 2019
Closed
Merged
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
@Zacqary @thompsongl
Fix cascade issue with adding className to EuiPageContent (elastic#2237)
93abb21 
* Fix cascade issue with adding className to EuiPageContent

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide left review comments

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiPageContent's max-width not stylable when using a class name
3 participants
@Zacqary @snide @thompsongl