Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox and EuiColorPicker don't allow prepend and append #2794

Closed
miukimiu opened this issue Jan 27, 2020 · 3 comments
Closed

EuiComboBox and EuiColorPicker don't allow prepend and append #2794

miukimiu opened this issue Jan 27, 2020 · 3 comments

Comments

@miukimiu
Copy link
Contributor

EuiComboBox and EuiColorPicker don't allow prepend and append.

For instance, the maps team is using a EuiComboBox and a EuiColorPicker and that's the result:

Screenshot 2020-01-27 at 12 24 03

Ideally, both components should allow prepend and append as the EuiFieldText allows.

@miukimiu
Copy link
Contributor Author

miukimiu commented Feb 3, 2020

I just added the append and prepend to the EuiComboBox without too much thinking and that was the result:

Screenshot 2020-02-03 at 20 02 32

So I need to rethink the design. 😛

@thomasneirynck
Copy link

Thanks for creating this. +1, it would really clean up the styling UX in Maps.

@miukimiu
Copy link
Contributor Author

I'm closing this issue in favor of #2943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants