-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds prepend and append to the EuiColorPicker #2819
Adds prepend and append to the EuiColorPicker #2819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cchaos. I just fixed the border-radius issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the test
.euiColorPicker__popoverAnchor { ...
is still in here. Is this going to change at all?
@@ -360,6 +381,7 @@ export const EuiColorPicker: FunctionComponent<EuiColorPickerProps> = ({ | |||
isOpen={isColorSelectorShown} | |||
closePopover={handleFinalSelection} | |||
zIndex={popoverZIndex} | |||
className={popoverClass} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Certainly possible; it just may be need to be done in a separate issue)
Ok, I'll create an issue. This PR 👍 LGTM!
Summary
Part of the #2794
This PR adds a prepend and append to the
EuiColorPicker
.More toggling options were added into the Forms Color Selection section of the docs.
Checklist