Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAccordion] Doesn't adjust exposed height when content height changes #3136

Closed
cchaos opened this issue Mar 20, 2020 · 3 comments · Fixed by #3160
Closed

[EuiAccordion] Doesn't adjust exposed height when content height changes #3136

cchaos opened this issue Mar 20, 2020 · 3 comments · Fixed by #3160

Comments

@cchaos
Copy link
Contributor

cchaos commented Mar 20, 2020

This usually happens the parent's width changes forcing the content to reflow and increase/decrease in height.

Screen Capture on 2020-03-20 at 14-50-36

The EuiAccordion component should watch for changes in the children's size and auto-adjust.

@chandlerprall
Copy link
Contributor

EuiAccordion uses EuiMutationObserver, and should be moved over to EuiResizeObserver. Note that there is a related bug in EuiResizeObserver with an open PR #3088, which means simply moving to EuiResizeObserver does not fix this in all browsers yet.

@winnllam
Copy link
Contributor

Hi, I'd like to try this!

@chandlerprall
Copy link
Contributor

@winnllam go for it! We'll take a look at a PR, but we do not assign issues out.

In general, once on Github, any issue can be worked on by the community. We sometimes reserve larger projects or ones that are core to our roadmap or design to be done internally. In these cases we mark these issues as assigned to a person using Github. We do not, as a policy, assign issues to community members. If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. Feel free to leave a comment to mark intent and avoid conflict.

EUI is built primarily by employees of Elastic. We try to do this in the open as much as possible, but do utilize closed meetings and other planning tools to dictate our longer term roadmap. We try to transcribe the decisions from these discussions in the form of specifications to Github issues for transparency. In general, once on Github, any issue can be worked on by the community. We sometimes reserve larger projects or ones that are core to our roadmap or design to be done internally. In these cases we mark these issues as `assigned` to a person using Github. We do not, as a policy, assign issues to community members. If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. Feel free to leave a comment to mark intent and avoid conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants