Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to EuiAccordion adjust exposed height #3160

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Fixes to EuiAccordion adjust exposed height #3160

merged 6 commits into from
Mar 31, 2020

Conversation

winnllam
Copy link
Contributor

@winnllam winnllam commented Mar 25, 2020 •
edited
Loading

Summary

Wasn't really sure where this would merge to :)
Closes #3136, now when changing the width, the accordion adjusts for the height.
before_resize
after_resize

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox (checked Firefox, no access to IE)
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@winnllam
Changed EuiMutationObserver to EuiResizeObserver
875122c 
Currently working in supported browers
@winnllam
Changed EuiMutationObserver to EuiResizeObserver
64a7fdf 
Currently working in supported browers
@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 25, 2020 •
edited
Loading

💚 CLA has been signed

@thompsongl
Copy link
Contributor

Hi, @winnllam

Thanks for the PR!
Be sure to sign the CLA (linked in an earlier comment). This is still in draft status, do you plan on adding more commits?

@winnllam
Copy link
Contributor Author

Hi @thompsongl,
I have signed the CLA; and I was reading the Contributing to EUI file and thought maybe I'll leave it in draft while I go through that document :)

@winnllam winnllam marked this pull request as ready for review March 26, 2020 02:54
cchaos
cchaos reviewed Mar 26, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@cchaos cchaos requested a review from thompsongl March 26, 2020 18:23
@cchaos
Copy link
Contributor

cchaos commented Mar 26, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3160/

cchaos
cchaos suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winnllam Can you please fix the dependency/package file issues?

@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

The yarn.lock file changes also need to be reverted

thompsongl
thompsongl approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3160/

@thompsongl
Copy link
Contributor

jenkins test this

(flaky test)

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3160/

@thompsongl thompsongl merged commit 93effed into elastic:master Mar 31, 2020
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
@winnllam winnllam deleted the f/accordion-height-changes branch May 26, 2020 18:03
@winnllam winnllam restored the f/accordion-height-changes branch May 26, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos requested changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiAccordion] Doesn't adjust exposed height when content height changes
4 participants
@winnllam @kibanamachine @thompsongl @cchaos