Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled button pointer event #3818

Closed
TAYTS opened this issue Jul 29, 2020 · 2 comments
Closed

Disabled button pointer event #3818

TAYTS opened this issue Jul 29, 2020 · 2 comments

Comments

@TAYTS
Copy link
Contributor

TAYTS commented Jul 29, 2020

May I propose to change the pointer-events to auto for disabled button so that the the cursor: not-allowed will be shown to indicate the disabled button state?

@include euiButtonContentDisabled;
color: $euiButtonColorDisabledText;
border-color: $euiButtonColorDisabled;
pointer-events: none;

@cchaos
Copy link
Contributor

cchaos commented Jul 29, 2020

Looks like this was a recent regression caused by the creation of the euiButtonContentDisabled() mixin that comes before the pointer-events: none. b02b840#diff-c9c0736fdff5dd43acc1168076e8a319

But I think in the above snippet, line 43 can just be removed entirely.

@TAYTS
Copy link
Contributor Author

TAYTS commented Jul 30, 2020

@cchaos I have submitted the PR to remove the pointer-events: none

@TAYTS TAYTS closed this as completed Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants