Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'pointer-events:none' for EuiButton&EuiButtonEmpty #3824

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

TAYTS
Copy link
Contributor

@TAYTS TAYTS commented Jul 30, 2020

Summary

Removed the pointer-events: none in both EuiButton and EuiButtonEmpty to not override the pointer-events in the button mixin euiButtonContentDisabled.

Issues: #3818

Checklist

  • Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@TAYTS TAYTS changed the title Removed 'pointer-events:none' for EuiButton&EuiButtonEmpty Remove 'pointer-events:none' for EuiButton&EuiButtonEmpty Jul 30, 2020
@snide
Copy link
Contributor

snide commented Jul 30, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3824/

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code and tested. TY for the help!

@snide snide merged commit 5bfb9d1 into elastic:master Jul 30, 2020
@TAYTS TAYTS deleted the feature/auto-button-pointer-event branch July 30, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants