Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data grid no longer adapts to its container in recent versions #3878

Closed
mmourafiq opened this issue Aug 8, 2020 · 3 comments · Fixed by #3894
Closed

Data grid no longer adapts to its container in recent versions #3878

mmourafiq opened this issue Aug 8, 2020 · 3 comments · Fixed by #3894
Labels
bug data grid dependencies Pull requests that update a dependency file

Comments

@mmourafiq
Copy link
Contributor

mmourafiq commented Aug 8, 2020

The example (Data grid adapts to its container) does not respect the height: 300 style and just expands beyond the container max height.

I noticed this issue in 27.3.0 and 27.4.0

@snide
Copy link
Contributor

snide commented Aug 8, 2020

Verified. I'll look into the regression that caused this on Monday and prioritize it. Offhand, looking at old data grid PR previews, this first showed up first #3700, but might have been caused by some other cascade.

@snide
Copy link
Contributor

snide commented Aug 11, 2020

This is due to the change in our downstream FocusTrap component which now uses https://github.com/theKashey/react-focus-on. The new lib doesn't allow style tags, and we had a height: 100% applied that is no longer being picked up. @thompsongl has a fix in that library itself, which should close the issue. theKashey/react-focus-on#47

Gonna see if that PR merges this week before addressing this with a hack in EUI itself.

@snide snide added the dependencies Pull requests that update a dependency file label Aug 11, 2020
@snide
Copy link
Contributor

snide commented Aug 11, 2020

I lied. FocusOn exposes a className, which the previous component did not. That works cleaner. PR up #3894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data grid dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants