Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow style prop on <FocusOn /> #47

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Allow style prop on <FocusOn /> #47

merged 2 commits into from
Aug 11, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 11, 2020 •
edited
Loading

Closes #46 by allowing style to be passed through to <ReactFocusLock /> lockProps from top-level <FocusOn />.

The resulting style attribute will be applied to the same div element targeted by the className prop.

@snide snide mentioned this pull request Aug 11, 2020
Closed
@theKashey
Copy link
Owner

Wow! Much easier than I thought 👍

@theKashey theKashey merged commit f1643ec into theKashey:master Aug 11, 2020
@snide snide mentioned this pull request Aug 11, 2020
Merged
5 tasks
@thompsongl
Copy link
Contributor Author

Nice! Glad this works for you.

I'm curious about your release process. When do you think the next version will be downloadable?

@thompsongl thompsongl deleted the style-prop branch August 11, 2020 22:11
@theKashey
Copy link
Owner

I would like to add more thing to the next release (#42) and publish the update today or tomorrow.

@theKashey
Copy link
Owner

Released in 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow style prop on <FocusOn />
2 participants
@thompsongl @theKashey