Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow style prop on <FocusOn /> #46

Closed
thompsongl opened this issue Jul 30, 2020 · 1 comment · Fixed by #47
Closed

Allow style prop on <FocusOn /> #46

thompsongl opened this issue Jul 30, 2020 · 1 comment · Fixed by #47
Assignees
@theKashey

Comments

@thompsongl
Copy link
Contributor

Similar to how className is applied, style could be applied to the main div (the one with the data-focus-lock-disabled attribute).

Happy to open a pull request, but wanted to ask your preference:

  1. Allow style prop only.
  2. Allow lockProps prop similar to react-focus-lock where any valid HTML or React attribute can be applied.

After switching to react-focus-on from react-focus-lock this has been the only API gap. Thanks for your work!
@thompsongl thompsongl mentioned this issue Jul 30, 2020
Closed
@theKashey theKashey self-assigned this Aug 2, 2020
@theKashey
Copy link
Owner

Valid point. A good addition to #42

@thompsongl thompsongl mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theKashey theKashey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow style prop on <FocusOn /> thompsongl/react-focus-on
2 participants
@theKashey @thompsongl