Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCodeEditor] Update React-Ace to newest #4314

Closed
PhaedrusTheGreek opened this issue Nov 27, 2020 · 3 comments
Closed

[EuiCodeEditor] Update React-Ace to newest #4314

PhaedrusTheGreek opened this issue Nov 27, 2020 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@PhaedrusTheGreek
Copy link
Contributor

React ace is currently 9.2.0 and EUI depends on 7.0.5 which is more than a year out of date
@kshitij86
Copy link

Would this break some things as they have major changes in v8 for react-ace and EUI depends on version 7.0.5?

@thompsongl
Copy link
Contributor

We need to formalize our decision with regard to EuiCodeEditor, but the current recommendation is to not use it for anything new. Our level of support for that component in the future will inform the dependency upgrades.

@thompsongl thompsongl added the dependencies Pull requests that update a dependency file label Nov 30, 2020
@thompsongl thompsongl changed the title Update React-Ace to newest [EuiCodeEditor] Update React-Ace to newest Nov 30, 2020
@cchaos
Copy link
Contributor

cchaos commented Mar 19, 2021

Closing for the recommendation mentioned above.

@cchaos cchaos closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cchaos @thompsongl @PhaedrusTheGreek @kshitij86