Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeEditor & EuiCodeBlock] Recommendations and migration guidance #3807

Closed
3 tasks done
chandlerprall opened this issue Jul 27, 2020 · 1 comment
Closed
3 tasks done
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Jul 27, 2020

EuiCodeEditor is now deprecated and will be removed in a future version of EUI

  • If you just want to represent a more or less static code snippet (max length around 15 lines) use EuiCodeBlock.
  • If you need capabilities to edit, or want to print longer code (or potentially don't know how long, because you're printing JSON from APIs), use CodeEditor (within Kibana).
  • Don't use EuiCodeEditor for new places more, and instead favor implementing a Monaco editor like CodeEditor.

Originally posted by @timroes in elastic/kibana#71425

@chandlerprall chandlerprall added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Jul 27, 2020
@cchaos cchaos changed the title Update EuiCodeEditor & EuiCodeBlock documentation with some more recommendations/guidance [EuiCodeEditor & EuiCodeBlock] Update documentation with some more recommendations/guidance Sep 20, 2020
@thompsongl thompsongl changed the title [EuiCodeEditor & EuiCodeBlock] Update documentation with some more recommendations/guidance [EuiCodeEditor & EuiCodeBlock] Recommendations and migration guidance Jul 27, 2021
@thompsongl
Copy link
Contributor

#5323 removed EuiCodeEditor and the docs have recommendations in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

No branches or pull requests

2 participants