[EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default #4537

cauemarcondes · 2021-02-17T19:28:14Z

On the Relative tab there's a flag called Round to the ${unit} that when enabled rounds the selected time.

I would like to have a similar flag on the commonly used section:

When that is enabled any option selected would be rounded.

I would also like to have a new property to enable it by default.

The text was updated successfully, but these errors were encountered:

hetanthakkar · 2021-02-23T12:05:54Z

@cchaos Can i take this issues ?

cchaos · 2021-02-23T16:45:17Z

This issue is marked as needs design as it will have to implement a new UI element to handle the feature request. I don't think we have a good path forward just yet.

hetanthakkar · 2021-02-23T18:29:04Z

@cchaos okay i will check it out once the design implementation is ready

github-actions · 2021-08-23T00:01:39Z

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

cchaos · 2021-08-23T14:42:59Z

Still valid

cchaos · 2021-08-23T21:34:16Z

Ideally, we'd just be able to pull that toggle out of being under the "Relative" tab specifically, and add to the popover as a footer.

Then it would show up for every tab (even "Now") but it will also have to be respected no matter which way the user has chosen to select a date.

dgieselaar · 2021-11-06T18:20:50Z

@cchaos curious if we can prioritise this? I think it'd be helpful for increasing shard request cache hit ratio. Especially with elastic/elasticsearch#79610, this seems like relatively low-hanging fruit with potentially a high positive impact on search performance/CPU usage in a cluster. I can also pick it up myself if these specs are final. This would allow us to move forward with elastic/kibana#94280 as well.

dgieselaar · 2021-11-19T13:16:13Z

I took a stab at this, but IMO the current handling of date rounding in the date picker leads to confusing behaviour. E.g., I actually think we want to round up, not down in most cases, and we want to apply date rounding on both the start and end of the date range. Right now I think the lower end will be rounded down and the upper end will be rounded up which leads to a bigger date range being selected than I would intuitively guess. E.g. if I select from: now-15m/m, to: now/m, 16 minutes will be selected instead of 15 (as far as I can tell). Maybe the date picker itself should not apply date rounding, and it should be left up to the consumer, only propagating a round property. Thoughts?

dgieselaar · 2021-11-19T14:34:31Z

Can someone elaborate why we round down by default? I see that we set date ranges like { from: 'now/d', to: 'now/d' }, but I don't understand why we're not setting those ranges to be { from: 'now-1d/d', to: 'now/d' } or { from: 'now/d', to: 'now+1d/d' }?

cchaos · 2021-11-22T16:01:09Z

I think it actually depends on whether you're adjusting the start or end date. It looks like it rounds down for start and up for end.

cchaos · 2021-11-22T16:02:40Z

Also, @nreese was instrumental in building this component. I wonder if he's got further insight?

nreese · 2021-11-22T16:42:14Z

The EUI date picker components just followed the model of the existing Kibana date picker components so all of these rounding decisions pre-date the EUI components.

The reason the start date is rounded down and the end date is rounded up can be seen in an example like today, where today is Nov 22nd.

With { from: 'now/d', to: 'now/d' }, rounding down for the start provides a value like 2021-11-22T00:00:00.000 and rounding up for the end provides a value like 2021-11-22T23:59:59.999. The time period only covers Today.
If you used { from: 'now-1d/d', to: 'now/d' } the start day would be Nov 21st even when rounded up and the time period would cover a sliver of Yesterday.
If you used { from: 'now/d', to: 'now+1d/d' } the end day would be Nov23rd even when rounded down and the time period would cover a sliver of Tomorrow.

Maybe @spalger or @lukasolson can provide more history?

nreese · 2021-11-22T16:46:32Z

One more thought, changing the rounding would be a breaking change as { from: 'now/d', to: 'now/d' } would no longer mean "today" if the rounding changed. Users can customize the quick select values in advanced setting so these can be custom values and I am not sure it would be possible to programmatically discover the user's intent with the time ranges and modify them correctly.

For better or worse, I don't think it's possible to change the rounding without breaking existing users.

dgieselaar · 2021-11-23T12:43:02Z

Yeah I don't expect this to change anytime soon given the impact. But it's very counterintuitive that { from: 'now-15m/m', to: 'now/m' } results in a 16m range, not a 15m range. e.g. @cchaos has selected 29 minutes in her screenshot even though the selected range runs from now-30m until now-2m, which I would expect to represent a range of 28m.

dgieselaar · 2021-11-23T13:00:27Z

Maybe a good workaround is to change the default values for date ranges? E.g.:

[
  {
    "from": "now/d",
    "to": "now/d",
    "display": "Today"
  },
  {
    "from": "now/w",
    "to": "now/w",
    "display": "This week"
  },
  {
    "from": "now-14m/m",
    "to": "now/m",
    "display": "Last 15 minutes"
  },
  {
    "from": "now-29m/m",
    "to": "now/m",
    "display": "Last 30 minutes"
  },
  {
    "from": "now-59m/m",
    "to": "now/m",
    "display": "Last 1 hour"
  },
  {
    "from": "now-23h/h",
    "to": "now/h",
    "display": "Last 24 hours"
  },
  {
    "from": "now-6d/d",
    "to": "now/d",
    "display": "Last 7 days"
  },
  {
    "from": "now-29d/d",
    "to": "now/d",
    "display": "Last 30 days"
  },
  {
    "from": "now-89d/d",
    "to": "now/d",
    "display": "Last 90 days"
  },
  {
    "from": "now-1y/d",
    "to": "now/d",
    "display": "Last 1 year"
  }
]

nreese · 2021-11-23T13:06:33Z

Maybe a good workaround is to change the default values for date ranges?

Any changes to the defaults should be coordinated with the Kibana repo. https://github.com/elastic/kibana/blob/main/src/plugins/data/server/ui_settings.ts#L356 is where Kibana's defaults come from.

How about opening this issue in the Kibana repo and get a discussion about defaults going there?

* [EuiSuperDatePicker] Sizing updates - Adds `width` and `isQuickSelectOnly` props - Adjusts styles accordingly with sensible min-widths - Updated Save Queries example to show auto width and reducing to quick select only when KQL is in focus - Fixed `dataTestSubj` -> `data-test-subj` - Removed ‘Show dates’ in favor of automatically expanding pretty format and opening start date popover * [EuiIcon] Added `timeRefresh` * [EuiFormControlLayout] Fix background of button prepend/appends with `readOnly` - And fixed border-radius for EuiSuperDatePicker with `append` * [EuiRefreshInterval] Using a toggle for start/stop - disabling inputs if paused - invalidating value if 0 or less - always rendering (moved render logic to quick select) - render in one row * [New] EuiAutoRefresh & EuiAutoRefreshButton components * [EuiSuperDatePicker] Simplify `isAutoRefreshOnly` to render the new EuiAutoRefresh component - Increases the default `refreshInterval` to `1000` / `1s` * [EuiSuperDatePicker] Added EuiAutoRefreshButton as an `append` when turned on - [prettyInterval()] added `shortHand` parameter * Fix color of prepend/append backgrounds in dark mode * Moved round switch to popover footer to prepare for #4537 * [EuiSuperDatePicker] Now supports `compressed` * [EuiSuperUpdateButton] Add support for `iconOnly` version and move `responsive` to customizable prop - Support in EuiSuperDatePicker with `showUpdateButton = ‘iconOnly’` - Fix min-widths on smaller screens * [EuiSuperUpdateButton] Splitting up prop types between internal and configurable

github-actions · 2022-05-23T00:06:43Z

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

sorenlouv · 2022-05-23T08:37:10Z

How about opening this issue in the Kibana repo and get a discussion about defaults going there?

Kibana issue follow-up: elastic/kibana#94280

github-actions · 2022-11-20T00:03:21Z

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

sorenlouv · 2022-11-20T22:57:37Z

I think it'd be helpful for increasing shard request cache hit ratio. Especially with elastic/elasticsearch#79610, this seems like relatively low-hanging fruit with potentially a high positive impact on search performance/CPU usage in a cluster.

...

Can someone elaborate why we round down by default? I see that we set date ranges like { from: 'now/d', to: 'now/d' }, but I don't understand why we're not setting those ranges to be { from: 'now-1d/d', to: 'now/d' } or { from: 'now/d', to: 'now+1d/d' }?

@dgieselaar Do we still need this from EUI or can we close this and instead start recommending users that they should change their defaults (perhaps through a warning in APM UI)?

JasonStoltz · 2023-02-06T18:35:12Z

We lost quite a bit of context for this issue recently. Is there still something that Kibana needs from EUI here?

dgieselaar · 2023-02-07T12:54:10Z

@JasonStoltz It's not a priority for us anymore, we've abandoned the idea of improving cache efficiency. I do think something is fundamentally broken with date rounding in the date picker, but I can see how changing that is a significant effort.

daveyholler · 2023-02-13T18:51:36Z

Since this is no longer a priority, we'll close this issue. If this changes, please open a new issue.

cchaos added the assign:designer label Feb 23, 2021

cchaos changed the title ~~[Date Picker] Add "Round to" flag on commonly used section and expose a property to enable it by default~~ [EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default Feb 23, 2021

github-actions bot added the stale-issue label Aug 23, 2021

cchaos removed the stale-issue label Aug 23, 2021

cchaos added assign:anyone good first issue and removed assign:designer labels Aug 23, 2021

cchaos added assign:engineer feature request and removed assign:anyone labels Nov 15, 2021

cchaos pushed a commit to cchaos/eui that referenced this issue Nov 15, 2021

Moved round switch to popover footer to prepare for elastic#4537

4d05eb1

cchaos mentioned this issue Nov 16, 2021

[EuiSuperDatePicker] Fixes for width and auto refresh #5383

Merged

10 tasks

github-actions bot added the stale-issue label May 23, 2022

github-actions bot removed the stale-issue label May 23, 2022

github-actions bot added the stale-issue label Nov 20, 2022

github-actions bot removed the stale-issue label Nov 21, 2022

daveyholler closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default #4537

[EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default #4537

cauemarcondes commented Feb 17, 2021

hetanthakkar commented Feb 23, 2021

cchaos commented Feb 23, 2021

hetanthakkar commented Feb 23, 2021

github-actions bot commented Aug 23, 2021

cchaos commented Aug 23, 2021

cchaos commented Aug 23, 2021 •

edited

Loading

dgieselaar commented Nov 6, 2021

dgieselaar commented Nov 19, 2021

dgieselaar commented Nov 19, 2021

cchaos commented Nov 22, 2021

cchaos commented Nov 22, 2021

nreese commented Nov 22, 2021 •

edited

Loading

nreese commented Nov 22, 2021

dgieselaar commented Nov 23, 2021 •

edited

Loading

dgieselaar commented Nov 23, 2021 •

edited

Loading

nreese commented Nov 23, 2021

github-actions bot commented May 23, 2022

sorenlouv commented May 23, 2022 •

edited

Loading

github-actions bot commented Nov 20, 2022

sorenlouv commented Nov 20, 2022 •

edited

Loading

JasonStoltz commented Feb 6, 2023

dgieselaar commented Feb 7, 2023

daveyholler commented Feb 13, 2023

[EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default #4537

[EuiSuperDatePicker] Add "Round to" flag on commonly used section and expose a property to enable it by default #4537

Comments

cauemarcondes commented Feb 17, 2021

hetanthakkar commented Feb 23, 2021

cchaos commented Feb 23, 2021

hetanthakkar commented Feb 23, 2021

github-actions bot commented Aug 23, 2021

cchaos commented Aug 23, 2021

cchaos commented Aug 23, 2021 • edited Loading

dgieselaar commented Nov 6, 2021

dgieselaar commented Nov 19, 2021

dgieselaar commented Nov 19, 2021

cchaos commented Nov 22, 2021

cchaos commented Nov 22, 2021

nreese commented Nov 22, 2021 • edited Loading

nreese commented Nov 22, 2021

dgieselaar commented Nov 23, 2021 • edited Loading

dgieselaar commented Nov 23, 2021 • edited Loading

nreese commented Nov 23, 2021

github-actions bot commented May 23, 2022

sorenlouv commented May 23, 2022 • edited Loading

github-actions bot commented Nov 20, 2022

sorenlouv commented Nov 20, 2022 • edited Loading

JasonStoltz commented Feb 6, 2023

dgieselaar commented Feb 7, 2023

daveyholler commented Feb 13, 2023

cchaos commented Aug 23, 2021 •

edited

Loading

nreese commented Nov 22, 2021 •

edited

Loading

dgieselaar commented Nov 23, 2021 •

edited

Loading

dgieselaar commented Nov 23, 2021 •

edited

Loading

sorenlouv commented May 23, 2022 •

edited

Loading

sorenlouv commented Nov 20, 2022 •

edited

Loading