Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDatePickerRange] Error state relies on color alone #4612

Closed
myasonik opened this issue Mar 4, 2021 · 6 comments · Fixed by #5918
Closed

[EuiDatePickerRange] Error state relies on color alone #4612

myasonik opened this issue Mar 4, 2021 · 6 comments · Fixed by #5918
Assignees

Comments

@myasonik
Copy link
Contributor

myasonik commented Mar 4, 2021

Example:
SuperDatePicker in error state has a red background

It'd seem to make sense to add a bottom border to those inputs like we do for other form error states (well, they're actually <button> elements here but they look like inputs so I think the point holds) but then you'd also need to make sure the focus state overrides the invalid state like it does for other inputs. (Otherwise you end up in a situation with no focus state when it's also invalid.)

Other ideas also welcome!

Related issues

@cchaos
Copy link
Contributor

cchaos commented Mar 4, 2021

An even better fix may be to actually adjust that arrow icon to become the alert icon. Since the error usually stems from the times being out of order.

@myasonik
Copy link
Contributor Author

myasonik commented Mar 4, 2021

Oh yeah, that reminds me: on the same thread, potentially the calendar on the left could become an alert icon. Then the date picker could get the same treatment and it might look nice having those two match like that.

@cchaos
Copy link
Contributor

cchaos commented Mar 4, 2021

The only worry I have about that is the association of where/how to fix the problem. Clicking the calendar replaced with alert icon button opens the quick select where all they can do is choose between some pre-fabbed options. Whereas, they most likely got into this error situation because they're manually updating the from vs to dates. So really we'd want to direct them to those to continue editing.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cchaos
Copy link
Contributor

cchaos commented Sep 1, 2021

Still valid

@cchaos
Copy link
Contributor

cchaos commented Nov 15, 2021

I did a quick investigation of this one and it actually just needs to be supported at the EuiDatePickerRange level. I'll tackle this once #5339 merges.

@cchaos cchaos changed the title [EuiSuperDatePicker] Error state relies on color alone [EuiDatePickerRange] Error state relies on color alone Nov 15, 2021
@cchaos cchaos self-assigned this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants