Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiResizableContainer] Add support for onResizeStart and onResizeEnd callback props #6225

Closed
davismcphee opened this issue Sep 9, 2022 · 2 comments · Fixed by #6236
Closed
Assignees
Labels
feature request good first issue help wanted The EUI team is looking for community members to pick up and implement this issue

Comments

@davismcphee
Copy link
Contributor

While implementing a resizable layout in Discover using EuiResizableContainer, we ran into some conflicts with react-reverse-portal. We were able to implement a workaround, but it involved setting up our own event listeners to watch for when resizing starts and ends.

It would simplify our use case a lot, and would probably be generally useful, if EuiResizableContainer accepted callback props for onResizeStart and onResizeEnd that would allow consumers to easily listen for when resizing starts and ends.

For our use case it's only important to listen for resizing triggered by a mouse click, but it might be worth considering whether these callbacks would apply to keyboard based resizing as well.

@cee-chen
Copy link
Contributor

cee-chen commented Sep 9, 2022

This definitely seems like a reasonable ask! We might want to look into adding support for EuiResizablePanel as well at the same time.

@davismcphee would someone on your team be open to opening a PR for EUI with this addition? The EUI team is currently fairly busy with the Emotion conversion, and this feels like a good first issue for another team to take on/help out with.

@davismcphee
Copy link
Contributor Author

@constancecchen Definitely! I'll assign it to myself and work on it since I'll be needing it soonest anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue help wanted The EUI team is looking for community members to pick up and implement this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants