Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Update layout for unified histogram #139446

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Aug 25, 2022

Summary

This PR adds support for resizing the histogram in Discover, and moves the view mode tabs below the histogram in preparation for the unified histogram project.

discover_resize

A la carte build: https://davismcphee-pr-139446-enhancement-discover-unified-histogra.kbndev.co

Flaky test run for new functional test: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1179

Resolves #138697.

Checklist

For maintainers

@davismcphee davismcphee added release_note:enhancement Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Aug 25, 2022
@davismcphee davismcphee self-assigned this Aug 25, 2022
@davismcphee davismcphee force-pushed the enhancement-discover-unified-histogram-layout branch from dbb0f08 to 951f1d2 Compare August 30, 2022 03:28
@davismcphee davismcphee force-pushed the enhancement-discover-unified-histogram-layout branch 2 times, most recently from d6bb507 to fa35e14 Compare September 8, 2022 17:23
@kertal
Copy link
Member

kertal commented Sep 13, 2022

@kertal Fixed the whitespace and resizable issue when using non time based data views. I also fixed a flexbox issue where the document explorer would overflow the container after resizing the window when the fixed panels layout was shown. Commit: 03cf671.

great thx!

One thing to consider when thinking about the hits row for non time based data views is that sometimes it also shows a reset button if it's a saved search: Web capture_12-9-2022_184715_localhost

For me this looks ok!


// useIsWithinBreakpoints triggers state updates which cause act
// issues and prevent our resize events from being fired correctly
// https://github.com/enzymejs/enzyme/issues/2073
Copy link
Member

@kertal kertal Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot for sharing and documenting!

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thx for inlining lots of explanations, this is very helpful! Tested locally with Chrome, Firefox, Safari. Thanks for taking care of the performance impact!

Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davismcphee Amazing work here Davis! Happy to see this become a reality. Just a comment, when I resize and I let go of the cursor, is it possible to go back to the initial state of the resize handler instead of staying with the blue bar on? Right now the only way to get rid of the blue bar is by doing an extra click outside and that feels a bit off.

resizing-blueBar

@kertal when will we be able to get rid of the beta badge for Field Statistics? that tab would look a lot better without it.

@kertal
Copy link
Member

kertal commented Sep 14, 2022

@kertal when will we be able to get rid of the beta badge for Field Statistics? that tab would look a lot better without it.

Thx Andrea, this is a good question, if I remember I hink it was less a technical choice to add beta than a design choice ... so, are we there now in a post-beta world? Interested also in @ryankeairns opinion here. FYI @ninoslavmiskovic

@andreadelrio
Copy link
Contributor

@kertal when will we be able to get rid of the beta badge for Field Statistics? that tab would look a lot better without it.

Thx Andrea, this is a good question, if I remember I hink it was less a technical choice to add beta than a design choice ... so, are we there now in a post-beta world? Interested also in @ryankeairns opinion here. FYI @ninoslavmiskovic

Design-wise I think that feature has been available long enough that we'd be ok to remove the badge.

@ryankeairns
Copy link
Contributor

+1 what Andrea said; design has been in place for some time. I suppose it's ultimately a product decision at this point

The only nitpick I have is whether should use small tabs as opposed to the the default size. The font seems a bit heavy, visually, relative to the rest of the content on the screen.

Here's a sneak peek at the small size:

Screen Shot 2022-09-14 at 12 44 57 PM

@kertal
Copy link
Member

kertal commented Sep 15, 2022

@kertal when will we be able to get rid of the beta badge for Field Statistics? that tab would look a lot better without it.

Thx Andrea, this is a good question, if I remember I hink it was less a technical choice to add beta than a design choice ... so, are we there now in a post-beta world? Interested also in @ryankeairns opinion here. FYI @ninoslavmiskovic

Design-wise I think that feature has been available long enough that we'd be ok to remove the badge.

ok, any objections removing beta of the field statistics dear @ninoslavmiskovic @ghudgins @qn895?

@ninoslavmiskovic
Copy link
Contributor

+1 what Andrea said; design has been in place for some time. I suppose it's ultimately a product decision at this point

The only nitpick I have is whether should use small tabs as opposed to the default size. The font seems a bit heavy, visually, relative to the rest of the content on the screen.

Here's a sneak peek at the small size:

Screen Shot 2022-09-14 at 12 44 57 PM

I agree with @ryankeairns regarding using a lighter font for the tabs.

Regarding removing the "beta" label. I am not aware of what the process is. I am used to look at performance, scalability, user feedback etc. before removing the beta.

When I look at Fullstory on how many users clicked on "Field Statistics" in Discover past 90 days, then it is 8%.

Before removing the beta - I would ask the team: Do we have enough user feedback? If that is a "no", then we should keep it and get some more. In my opinion getting user feedback is one of the main purposes running "Beta" programs, and "alpha".

Skærmbillede 2022-09-15 kl  09 46 55

@davismcphee
Copy link
Contributor Author

@andreadelrio The resize button is now blurred after resizing with a mouse which gets rid of the focus styles.

@ryankeairns I've updated the layout to use small tabs instead:
Screen Shot 2022-09-15 at 2 13 09 PM

Regarding the badge, I can make the change whenever we come to a decision, but it would be best if we could decide soon since the goal is to get this in before feature freeze on Sept 20.

@kibanamachine kibanamachine requested a review from a team as a code owner September 15, 2022 17:21
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@andreadelrio andreadelrio self-requested a review September 15, 2022 21:58
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates, LGTM.

@kertal
Copy link
Member

kertal commented Sep 19, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 472.7KB 477.1KB +4.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 56680ab into elastic:main Sep 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 19, 2022
@davismcphee davismcphee deleted the enhancement-discover-unified-histogram-layout branch September 19, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Redesign layout to prepare for unified_histogram
8 participants