Alert & Error Icon Follow-up Considerations

[MichaelMarcialis]

As a follow-up to a recent PR that updates the alert icon and adds a new error icon (#6550), I think it may be wise to consider the following:

• Consider deprecating/removing the crossInACircleFilled icon for two reasons: 1) It's very close to the new error icon, and 2) it perpetuates a problematic pattern where some EUI icons offer regular/circled/filled variants, which often lead to a lot of interface inconsistencies. I imagine it can be replaced with either a regular cross or error icon, as the context dictates.
• Consider changing the current alert icon's name to warning. Doing so will make it clearer to developers that we have specific icons to use for error and warning cases.

Curious to know the team's thoughts on these suggestions. Thanks!

[JasonStoltz]

Deprecating or removing the crossInACircleFilled icon sounds reasonable, especially if it's problematic from an end user perspective. At a quick glance, I see about 20 instances of it being used in Kibana.

I'm less certain about changing "alert" to "warning", but have no strong opinion.

@miukimiu Do you have any opinion on any of this?

[elizabetdev]

I agree with deprecating the crossInACircleFilled in favor of the new error icon.

Changing the current alert icon's name to warning it also makes sense to me.

In elastic/kibana#151413 @boriskirov made a clear point on how to differentiate the alert icon and error.

It's important to differentiate them clearly as errors and warning messages are semantically different states. It's widely considered that errors maybe fatal errors and warnings are never fatal.

And this makes me agree with @MichaelMarcialis that the icon should be called warning.

Doing so will make it clearer to developers that we have specific icons to use for error and warning cases.

I'll assign this issue to me.