[SuperDatePicker] Add a disabled state default text #6814
Assignees
Labels
Comments
Merged
2 tasks
|
Hey @stratoula, @cee-chen is planning to take a look at implementing this week. |
Merged
9 tasks
|
Amazing! Thank you @JasonStoltz and @cee-chen! |
stratoula
added a commit
to elastic/kibana
that referenced
this issue
May 31, 2023
…mode (#158531) ## Summary Closes #154334 This PR: - make the text based languages to work with adhoc dataviews and not permanent dataviews. The text based languages will not be related with dataviews - enables the timepicker always for text based languages - the timepicker is disabled if the index pattern doesn't have an @timestamp field - the timepicker is enabled if the index pattern has an @timestamp field - the timepicker is enabled if the index pattern doesn't have an @timestamp field but there is a dirty state (user is writing the query and hasn't hit the update button. We do that to give the user the ability to change the timepicker with the query - An info text has been added to the editor footer to inform the users about the @timestamp existence The timepicker in the disabled state needs to have a disabled status text (All time) but this is not possible atm. I have created an issue to eui elastic/eui#6814 to add this property. This is going to be tackled before the 8.9 FF but we don't want to block this PR <img width="1839" alt="image" src="https://github.com/elastic/kibana/assets/17003240/8fc0a492-1f00-41b6-a4a6-b0527725931f"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In ESQL mode we have 2 kind of indices:
For the first case is going to be handled as:
Disabing the SuperDatePicker means that we return all the data to the user. So in the screenshot below we want to depict to the user this information. So instead of having disabled and Last 24 hours, we want to depict disabled and a disabled status text
All TimeDescribe the solution you'd like
We would like a new property for the disabled status, a placeholder text to support the case I describe above. As ESQL is a high priority project it would be amazing if we could have it before the 8.9 FF 🙏
The text was updated successfully, but these errors were encountered: