Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty space below image on IE #971

Closed
bhavyarm opened this issue Jul 5, 2018 · 2 comments · Fixed by #973
Closed

Empty space below image on IE #971

bhavyarm opened this issue Jul 5, 2018 · 2 comments · Fixed by #973
Assignees
@cchaos
Labels
bug

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Jul 5, 2018

We have this huge space below image in IE11 which is causing the part first of this bug:elastic/kibana#20469

IE image:

empty_space_ie

Firefox image all good:

no_space_firefox
@bhavyarm bhavyarm added the bug label Jul 5, 2018
@bhavyarm bhavyarm mentioned this issue Jul 5, 2018
Closed
@cchaos cchaos self-assigned this Jul 5, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue Jul 6, 2018
IE Fixes (mostly flex box)
ef3d9f1 
- Fixed modal overflow issue
- Fixed flex wrapping elements in docs and added utility class (`.euiIEFlexWrapFix`) for consumers
- Fixed image shrink issues (fixes elastic#971)
- Fixed home card layout that was still using `<Link>`. I added the `secureRel` stuff to `EuiCard` to support app linking.
- Added some callouts to mention where IE flex bugs may occur (especially for when a generalized fix cannot be implemented)
@cchaos cchaos mentioned this issue Jul 6, 2018
Merged
@cchaos
Copy link
Contributor

cchaos commented Jul 6, 2018

@bhavyarm I think the Kibana issue you linked to was wrong, I think you mean to link to: elastic/kibana#20470

@cchaos
Copy link
Contributor

cchaos commented Jul 6, 2018

Though the ticket you referenced was in fact fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IE Fixes (mostly flex box) cchaos/eui
2 participants
@cchaos @bhavyarm