Give close button on flyout a data-test-subj

[stacey-gammon]

Will be useful for elastic/kibana#20163

[cchaos]

Is this something that can be passed down via {...props}? Like if we added closeButtonProps that accepted an object of props and here just spread them into the close button.

My worry with hard-coding this value is if there are multiple flyouts on the page, it might not know which close button is being targeted and so you could get a false pass.

[stacey-gammon]

yea that's a downside. We could do that too. I don't feel strongly either way, though if we do go that route, we could put onClose in that too (but then it should be onClick) closeButtonProps = { onClick, data-test-subj, aria-label }.

I'm game with either.

[cjcenizal]

I think this is the kind of situation where it makes sense to hard-code the data-test-subj. We do the same thing for the close button in toasts and for the clear and toggle buttons in the combo box, and rely on the consumer to add a scoping data-test-subj to the particular instance of the component itself to avoid conflicts.

[cjcenizal]

LGTM! Was the reformatting done automatically by your IDE @stacey-gammon?

[cjcenizal]

Looks like the Jest snapshots need to be updated.

[cjcenizal]

Maybe change this to:

- Gave `EuiFlyout` close button a `data-test-subj` etc...

for consistency?

[stacey-gammon]

Was the reformatting done automatically by your IDE @stacey-gammon?

yep. I have since turned it off for the eui repo because it reformatted all of CHANGELOG.md.

[stacey-gammon]

Re: jest snapshots. Can you walk me through that @cjcenizal ? Looks like the commands are a bit different for eui vs Kibana. I ran yarn then yarn jest but everything failed with:

  ● renders EuiModalBody

    
          Enzyme Internal Error: Enzyme expects an adapter to be configured, but found none. To
          configure an adapter, you should call `Enzyme.configure({ adapter: new Adapter() })`
          before using any of Enzyme's top level APIs, where `Adapter` is the adapter
          corresponding to the library currently being tested. For example:
    
          import Adapter from 'enzyme-adapter-react-15';
    
          To find out more about this, see http://airbnb.io/enzyme/docs/installation/index.html

don't see anything in contributing doc re: how to run jest tests.

[stacey-gammon]

nm i found the docs. I need to read more thoroughly. :)

[cjcenizal]

nm i found the docs

Oh good because I was just about to look for them! 😄