-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typescript syntax error #1012
Merged
chandlerprall
merged 4 commits into
elastic:master
from
chandlerprall:bug/typescript-keycodes
Jul 13, 2018
Merged
Fix typescript syntax error #1012
chandlerprall
merged 4 commits into
elastic:master
from
chandlerprall:bug/typescript-keycodes
Jul 13, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reference, this was the error from the Kibana CI:
|
chandlerprall
force-pushed
the
bug/typescript-keycodes
branch
from
July 13, 2018 20:27
b6411ad
to
a88c528
Compare
w33ble
approved these changes
Jul 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how typescript and its definitions work, but I'll approve this if it makes you feel better about the change.
chandlerprall
force-pushed
the
bug/typescript-keycodes
branch
from
July 13, 2018 20:30
a88c528
to
4bedd10
Compare
jenkins test this |
chandlerprall
force-pushed
the
bug/typescript-keycodes
branch
from
July 13, 2018 21:14
d73c703
to
544c248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports elastic/kibana#20790 (comment)