Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript syntax error #1012

Merged
merged 4 commits into from
Jul 13, 2018

Conversation

chandlerprall
Copy link
Contributor

@w33ble
Copy link
Contributor

w33ble commented Jul 13, 2018

For reference, this was the error from the Kibana CI:

info  [kibana-oss] Transpiling sources with typescript compiler
18:42:24    │ debg  $ /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/node_modules/typescript/bin/tsc --pretty true
18:42:31    │ debg  ../../node_modules/@elastic/eui/src/services/key_codes.d.ts:14:4 - error TS1036: Statements are not allowed in ambient contexts.
18:42:31    │ debg  
18:42:31    │ debg  14   };
18:42:31    │ debg        ~
18:42:31    │ debg  
18:42:31    │ debg  
18:42:31    │ERROR  failure
18:42:31    │ERROR  Error: Command failed: /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/node_modules/typescript/bin/tsc --pretty true
18:42:31    │       
18:42:31    │       ../../node_modules/@elastic/eui/src/services/key_codes.d.ts:14:4 - error TS1036: Statements are not allowed in ambient contexts.
18:42:31    │       
18:42:31    │       14   };
18:42:31    │             ~
18:42:31    │       
18:42:31    │       
18:42:31    │       
18:42:31    │           at makeError (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/node_modules/execa/index.js:172:9)
18:42:31    │           at Promise.all.then.arr (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/node_modules/execa/index.js:277:16)
18:42:31    │           at <anonymous>
18:42:31    │           at process._tickCallback (internal/process/next_tick.js:188:7)

Copy link
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how typescript and its definitions work, but I'll approve this if it makes you feel better about the change. :shipit:

@chandlerprall
Copy link
Contributor Author

jenkins test this

@chandlerprall chandlerprall merged commit d4fec84 into elastic:master Jul 13, 2018
@chandlerprall chandlerprall deleted the bug/typescript-keycodes branch July 13, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants