Add typings for EuiBadge #1034
Merged
Add typings for EuiBadge #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Jul 19, 2018
src/components/badge/index.d.ts
Outdated
| } | ||
|
|
||
| export const EuiBadge: SFC< | ||
| CommonProps & HTMLAttributes<HTMLSpanElement> & EuiBadgeProps |
There was a problem hiding this comment.
if onClick prop is passed then a button is rendered around the span, this should intersect HTMLSpanElement's attributes with HTMLButtonElement for completeness.
chandlerprall
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add typings for the EuiBadge component.
Testing
Before these changes:
Export the changes from my local
node_modules:EuiBadgenow a recognized type: