Fix EuiOutsideClickDetector to work when its nested inside itself #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Jul 19, 2018
| @@ -32,7 +32,7 @@ export class EuiOutsideClickDetector extends Component { | |||
| // virtual DOM and executes EuiClickDetector's onClick handler, | |||
| // stamping the id even though the event originates outside | |||
| // this component's reified DOM tree. | |||
| this.id = htmlIdGenerator(); | |||
| this.id = htmlIdGenerator()(); | |||
There was a problem hiding this comment.
Curious: What does the double parens do/mean?
There was a problem hiding this comment.
it's calling the function that htmlIdGenerator returns; The initial use of the function was incorrect here but worked for the detector's purposes for reasons. Calling htmlIdGenerator returns a function which can then be called with our without a prefix, and that returns a string value.
|
jenkins test this |
cjcenizal
approved these changes
Jul 19, 2018
chandlerprall
deleted the
bug/1037-nested-outclick-click-detector-fighting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037 by tracking all unique IDs of a bubbling event's encountered
EuiOutsideClickDetectors. This prevents a wrapping outside click detector from interfering with any children detectors.