Make EUIXYChart responsive using ResizeObserver #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
reviewed
Jul 20, 2018
| width: 0, | ||
| }; | ||
| this.containerRef = React.createRef(); | ||
| this.ro = new ResizeObserver(this.createResizeObserver); |
There was a problem hiding this comment.
I would rather call this onResize since it's not really a factory that you call that would create anything.
cchaos
reviewed
Jul 20, 2018
CHANGELOG.md
Outdated
| - To make it more accessible, added a random id to `EuiSwitch`'s id prop if none is passed. ([#779](https://github.com/elastic/eui/pull/779)) | ||
| - Fixed `EuiXYChart` wrong responsive resize in a flexbox layout ([#1041](https://github.com/elastic/eui/pull/1041)) |
| }, | ||
| ], | ||
| demo: ( | ||
| <div style={{ margin: 60 }}> |
There was a problem hiding this comment.
Don't need the extra margin here. Let it fill the width of the example area.
| text: ( | ||
| <div> | ||
| <p> | ||
| You can omit <EuiCode>width</EuiCode> ando/or <EuiCode>height</EuiCode> |
| You can omit <EuiCode>width</EuiCode> ando/or <EuiCode>height</EuiCode> | ||
| prop and the chart takes the full width and/or height of it's parent. | ||
| </p> | ||
| <p>The parent container needs to have computed a height and or width.</p> |
There was a problem hiding this comment.
add "/" after "and" to be "and/or"
chandlerprall
approved these changes
Jul 20, 2018
cchaos
approved these changes
Jul 25, 2018
|
@markov00 I think this is safe to merge. I have been playing around with it in the prototype and it's been working much nicer. |
|
@markov00 Can you rebase and merge this when you have time. It's holding up @cjcenizal's rename PR #1050 which would be nice to get in. |
This drops the use of native react-vis makeVisFlexible in favour of ResizeObserver to support resizing of the chart container as in kibana dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the use of native
react-vismakeVisFlexibleHOC in favour of the ResizeObserver to support resizing of the chart container as in kibana dashboard.It also fix some resizing problem in flexbox discrovered on the new editor POC by @cchaos.