Assign EuiComboBox data-test-subj to the options list with a '-optionsList' suffix #1054
Conversation
cjcenizal
force-pushed
the
combo-box-list-test
branch
from
f24f59e
to
4785b84
Compare
CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ No public interface changes since `3.2.1`. | |||
| - Added types for `EuiToast`, `EuiGlobalToastList`, and `EuiGlobalToastListItem` ([#1045](https://github.com/elastic/eui/pull/1045)) | |||
| - Added a handful of third-party logos to `EuiIcon` ([#1033](https://github.com/elastic/eui/pull/1033)) | |||
|
|
|||
| **Breaking changes** | |||
|
|
|||
| - `EuiComboBox` now applies the provided `data-test-subj` to its options list element with the suffix `-optionsList` so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element. This is a break from the previous `data-test-subj` which was simply `comboBoxOptionsList`. ([#1054](https://github.com/elastic/eui/pull/1054)) | |||
There was a problem hiding this comment.
I don't see this as a breaking change?
There was a problem hiding this comment.
Kibana has tests which rely on the data-test-subj="comboBoxOptionsList" selector, and they'll break once we intake this change.
There was a problem hiding this comment.
I tried to find that line in the PR, but couldn't (sorry). Can that attribute be left in place and just add the one for individual options?
There was a problem hiding this comment.
Good idea! I'll make that change.
|
@chandlerprall Thanks, done. |
|
@cjcenizal Thanks. I'll fix. |
|
@cjcenizal err, I mean, thanks for fixing. |
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ No public interface changes since `3.2.1`. | |||
|
|
|||
| ## [`3.2.1`](https://github.com/elastic/eui/tree/v3.2.1) | |||
|
|
|||
| - `EuiComboBox` now applies the provided `data-test-subj` to its options list element with the suffix `-optionsList` so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element. This is in addition to the existing `data-test-subj="comboBoxOptionsList"`. ([#1054](https://github.com/elastic/eui/pull/1054)) | |||
There was a problem hiding this comment.
This should be under master and labeled as a breaking change.
There was a problem hiding this comment.
not a breaking change, this is now only adding new attributes without removing the old one (but yes, under master)
This is so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element.