Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow * and _ characters in Search AST 'word's #1058

Merged
merged 4 commits into from
Aug 6, 2018
Merged

Allow * and _ characters in Search AST 'word's #1058

merged 4 commits into from
Aug 6, 2018

Conversation

chandlerprall
Copy link
Contributor

Fixes #951 by adding _ and * as allowed characters in a search term.

@chandlerprall chandlerprall requested a review from uboness July 30, 2018 18:05
@chandlerprall chandlerprall requested a review from cjcenizal August 3, 2018 17:33
cjcenizal
cjcenizal approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as advertised. Code LGTM.

@chandlerprall chandlerprall merged commit 4f3746b into elastic:master Aug 6, 2018
@chandlerprall chandlerprall deleted the bug/951-searchbar-illegal-characters branch August 6, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@uboness uboness Awaiting requested review from uboness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @cjcenizal