Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a minified version of each theme file using cssnano #1070

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

pugnascotia
Copy link
Contributor

Like the summary says. I thought it might be slow to re-run PostCSS but in practice I couldn't tell. We still only run sass once.

I struggled to generate source maps, so if we want them then I'd appreciate some input.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pulled and ran the compile-scss script, verified output looks correct (retains autoprefixef as it should, etc)

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the modified yarn.lock, then this looks great :)

@pugnascotia
Copy link
Contributor Author

After a discussion with @chandlerprall, we're going to merge the changes as-is.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My yarn has a difference in opinion, going to go with @pugnascotia's original yarn.lock changes.

all LGTM!

@pugnascotia pugnascotia merged commit 9566f74 into elastic:master Aug 1, 2018
@pugnascotia pugnascotia deleted the minify-css branch November 8, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants