Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiMutationObserver does not require children #1076

Merged
merged 3 commits into from
Aug 2, 2018
Merged

EuiMutationObserver does not require children #1076

merged 3 commits into from
Aug 2, 2018

Conversation

chandlerprall
Copy link
Contributor

Closes #1073

EuiMutationObserver does not actually require children to be passed. In #1073 the warning was given because EuiFieldValueSelectionFilter's searchBox or content could be null, which propagates to the mutation observer as a null child.

@chandlerprall chandlerprall requested a review from cjcenizal August 2, 2018 18:30
cjcenizal
cjcenizal approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this fixes the problem. Thanks for looking into this!

@chandlerprall chandlerprall merged commit 7668226 into elastic:master Aug 2, 2018
@chandlerprall chandlerprall deleted the bug/1073-search-bar-children branch August 2, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @cjcenizal