Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaults to borders and adjust shadows #1079

Merged
merged 6 commits into from
Aug 2, 2018
Merged

Add defaults to borders and adjust shadows #1079

merged 6 commits into from
Aug 2, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Aug 2, 2018

Fixes #1072 and #1056

I adjusted the slight hue color to just be a bit darker and less opaque for the large shadows. Here are some before and afters:

And dark mode pretty much stays the same:

screen shot 2018-08-02 at 15 33 58 pm

screen shot 2018-08-02 at 15 33 40 pm

Oh and I threw in that quick fix we saw with the toggle icon button in the docs.

snide
snide approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Reviewed the code and checked in the browser. Even checked to make sure the reverse (dark theme, but light background) also worked. 💯

chandlerprall
chandlerprall approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; tried docs out in browser and it looks great

@cchaos cchaos merged commit d4d5baf into elastic:master Aug 2, 2018
@cchaos cchaos deleted the add-defaults branch August 2, 2018 21:34
@cchaos
Copy link
Contributor Author

cchaos commented Aug 2, 2018

I'm a dummy, I forgot a changelog, coming up

@cchaos cchaos mentioned this pull request Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Border colors need !default
3 participants
@cchaos @chandlerprall @snide