Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resize-observer-polyfill as a dependency #1085

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Add resize-observer-polyfill as a dependency #1085

merged 2 commits into from
Aug 3, 2018

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 3, 2018

Fix #1084 Add the resize-observer-polyfill as a dependency, previously was a devDependency and causes missing dependency error.

cchaos
cchaos approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

chandlerprall
chandlerprall approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@markov00 markov00 merged commit 4b535c2 into elastic:master Aug 3, 2018
@markov00 markov00 deleted the fix/1084-resize-observer-dep branch August 3, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markov00 @chandlerprall @cchaos