Add typings for EuiToolTip and EuiIconTip #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Aug 6, 2018
src/components/tool_tip/index.d.ts
Outdated
| import { ReactElement, ReactNode, SFC } from 'react'; | ||
|
|
||
| declare module '@elastic/eui' { | ||
| export type PositionsToClassNameMap = |
There was a problem hiding this comment.
This should be named more explicitly against the icons, and doesn't have to reference that they're from the map: TooltipPositions. This aligns with the array "enum" that is used in the proptypes (POSITIONS vs positionsToClassNameMap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add typings for the
EuiToolTipandEuiIconTipcomponents.Testing
Before changes:
After adding types to my
node_modules:Reviewing this PR