Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy button that copies text to clipboard #1112

Merged
merged 11 commits into from
Aug 14, 2018
Merged

copy button that copies text to clipboard #1112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e2d6a02
copy button that copies text to clipboard
nreese Aug 10, 2018
5859058
change log
nreese Aug 10, 2018
6b02dfb
merge with master
nreese Aug 13, 2018
c6f3268
move to component under utilities
nreese Aug 13, 2018
c87f029
update change log
nreese Aug 13, 2018
b8196ca
Merge branch 'master' of github.com:elastic/eui into copy_botton
nreese Aug 13, 2018
8c7a378
make children be a function
nreese Aug 13, 2018
9247100
make copy messages be props
nreese Aug 13, 2018
1860b1b
add comments on props, pass rest, more details in usage example
nreese Aug 14, 2018
45c41d9
do not provide default beforeMessage
nreese Aug 14, 2018
d8724a4
besure to check for title in tooltip
nreese Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/copy/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ EuiCopy.propTypes = {
* Tooltip message displayed after copy function is called that lets the user know that
* 'textToCopy' has been copied to the clipboard.
*/
afterMessage: PropTypes.string,
afterMessage: PropTypes.string.isRequired,

/**
* Function that must return a Component. First argument is 'copy' function.
Expand All @@ -75,7 +75,6 @@ EuiCopy.propTypes = {
};

EuiCopy.defaultProps = {
beforeMessage: 'Copy',
afterMessage: 'Copied',
};

4 changes: 2 additions & 2 deletions src/components/tool_tip/tool_tip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class EuiToolTip extends Component {
);

let tooltip;
if (visible) {
if (visible && content) {
Copy link
Contributor

@cchaos cchaos Aug 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last thing, but because tooltips accept title's as well can you change this to be if (visible && (content || title))

tooltip = (
<EuiPortal>
<EuiToolTipPopover
Expand Down Expand Up @@ -205,7 +205,7 @@ EuiToolTip.propTypes = {
/**
* The main content of your tooltip.
*/
content: PropTypes.node.isRequired,
content: PropTypes.node,

/**
* An optional title for your tooltip.
Expand Down