Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1102 combo box typedefs #1115

Merged

Conversation

chandlerprall
Copy link
Contributor

Closes #1102 by adding TS typings for EuiComboBox and its related sub-components.

@chandlerprall chandlerprall force-pushed the feature/1102-combo-box-typedefs branch from c3483e2 to f064095 Compare August 15, 2018 15:16
@chandlerprall
Copy link
Contributor Author

@stacey-gammon would you mind reviewing these changes?

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM! Pulled locally and made sure no type errors for a file that uses EuiComboBox. Quick glance at types compared to props in code look accurate. Thanks!!

@chandlerprall chandlerprall merged commit f67b408 into elastic:master Aug 28, 2018
@chandlerprall chandlerprall deleted the feature/1102-combo-box-typedefs branch August 28, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants