Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip positioning when content updates #1116

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Update tooltip positioning when content updates #1116

merged 3 commits into from
Aug 29, 2018

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Aug 15, 2018 •
edited
Loading

Fixes #996 by making EuiToolTip listen for DOM changes within the tooltip content and then re-positioning its popover.

I tested this by adding a beforeMessage prop to the copy button example.

cchaos
cchaos approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Youp, works for me. I couldn't test in IE11 because of #1118

@snide snide mentioned this pull request Aug 28, 2018
Closed
@chandlerprall chandlerprall merged commit 39c94c1 into elastic:master Aug 29, 2018
@chandlerprall chandlerprall deleted the bug/996-tooltip-dynamic-sizing branch August 29, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @cchaos