Add typedefs for EuiAvatar component and color service #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@stacey-gammon Do you mind just glancing over these TS defs? Our resident TS expert, @chandlerprall is out for the next week. |
src/services/color/index.d.ts
Outdated
| type rgbDef = [number, number, number]; | ||
|
|
||
| export const hexToRbg: (hex: string) => rgbDef; | ||
| export const rbgToHex: (rbg: string) => string; |
There was a problem hiding this comment.
(rbg: rgbDef) => string; ?
There was a problem hiding this comment.
If I understand the function correctly (https://github.com/legrego/eui/blob/typedef-updates/src/services/color/rgb_to_hex.js#L2), rbgToHex accepts a string, rather than an array of numbers.
I did transpose rgb into rbg by mistake, so I'll fix that now.
legrego
added a commit
to elastic/kibana
that referenced
this pull request
Aug 16, 2018
…19497) This replaces the existing Modal with a smaller Popover which is less intrusive. The popover also features a search bar for finding the desired Space when there are 8 or more Spaces to choose from. ### Details When there are less than 8 spaces available, the selector will render a simple list of spaces. When there are >= 8 spaces available, the selector will also render a search bar to let users search for their space. ### Prerequisites - [x] Merge #18862 into `spaces-phase-1` ### Known Issues - elastic/eui#1043 (fixed in `v3.2.0`) - elastic/eui#1052 (fixed in `v3.2.1`) - Missing typdefs (not a blocker to merge): elastic/eui#1120
|
Thanks for the review @stacey-gammon! @cchaos any objections to merging this? |
|
Nope, go for it! |
legrego
added a commit
to legrego/eui
that referenced
this pull request
Aug 23, 2018
legrego
added a commit
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typedefs for the following:
EuiAvatarcomponentcolorservice